Skip to content

Restore conventions for uninitialized properties and fix flavor-specific configs not picking up the default resource path #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2023
Merged

Restore conventions for uninitialized properties and fix flavor-specific configs not picking up the default resource path #74

merged 2 commits into from
Dec 10, 2023

Conversation

@adriangl
Copy link
Contributor

Github issue (delete if this does not apply)

Resolves #72

PR's key points

The PR fixes several issues after the 4.1.0 update, specifically:

  • Fix some uninitialized variables' errors, as specified in Issue when applying the plugin #72
  • Clarifies some of the README requirements so users don't have issues with the plug-in
  • Fix flavor-specific configs not picking up the default resource path which got broken after changing to lazy initialization

Definition of Done

  • Changes summary added to CHANGELOG.md
  • Documentation added to README.md (if a new feature is added)
  • Tests added (if new code is added)
  • There is no outcommented or debug code left
@adriangl adriangl self-assigned this Dec 10, 2023
@adriangl adriangl merged commit 50e2681 into master Dec 10, 2023
@adriangl adriangl deleted the bugfix/4.1.0-bugfixes branch December 10, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@adriangl