Send tags as String JSON array instead of list of form URL encoded args #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adriangl approved these changes Aug 28, 2023
There was a problem hiding this comment.
Hi @bogdanzurac!
Thanks for the contribution! The code looks good to me, I've tested it in a dummy PoEditor project and now tags are properly formatted, so I'd say it's good to me ;)
Just don't forget filling in the checks in the PR's description to add the finishing touches to the PR and merge it.
| @adriangl you're most welcome! I've added the fix to the changelog, PR should now be ready to go. |
| Merged! Thanks a lot for the contribution @bogdanzurac! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Github issue (delete if this does not apply)
Resolves #69
PR's key points
Use Moshi to serialize the list of tags to a JSON array before sending to Poeditor API
How to review this PR?
Just check code style and testing
Definition of Done