Skip to content

Conversation

@adriangl
Copy link
Contributor

PR's key points

The PR adds the unquoted flag to the PoEditor options so users can download strings without quotes from PoEditor.
This feature comes from a question in #61.

How to review this PR?

Check that the flag works as expected.

Notes

More information here: https://poeditor.com/kb/quotes-in-android-string-resources

Definition of Done

  • Changes summary added to CHANGELOG.md
  • Documentation added to README.md (if a new feature is added)
  • Tests added (if new code is added)
  • There is no outcommented or debug code left
@adriangl adriangl self-assigned this Dec 27, 2022
@adriangl adriangl force-pushed the feature/unquoted-flag branch from c9419f8 to 339d1aa Compare December 27, 2022 11:04
@adriangl
Copy link
Contributor Author

Hi @carlosrivin!
I checked up what you mentioned in #61 and it was easy enough to add said feature, so here it is :D

Please take a look at it with this version of the plug-in.

classpath "com.github.hyperdevs-team:poeditor-android-gradle-plugin:feature~unquoted-flag-SNAPSHOT"

Let me know if it works for you ;)

Thanks!

@carlosrivin
Copy link

Awesome. Thanks a lot. Early January I'll check it. I'm on vacations now.

@adriangl
Copy link
Contributor Author

Hi @carlosrivin! Did you manage to test the branch? Let me know so I can get it merged ;)

@carlosrivin
Copy link

It works!!! Thanks.
Sorry for the delay.

@adriangl adriangl merged commit b77e03f into master Jan 22, 2023
@adriangl adriangl deleted the feature/unquoted-flag branch January 22, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants