Add support for custom resource file name #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gustavaa changed the title 
adriangl requested changes Nov 13, 2022
src/main/kotlin/com/hyperdevs/poeditor/gradle/xml/AndroidXmlWriter.kt Outdated Show resolved Hide resolved
adriangl approved these changes Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR's key points
This PR makes it possible to define a custom name for the fetched string resource file, e.g.
poeditor_strings.xml. This is useful in certain projects where you have multiple sources of strings used and PoEditor is just one of these.How to review this PR?
Thoroughly, I found no good exisiting test class to add tests to for this.
Related Issues (delete if this does not apply)
Definition of Done