Added the possibility to define the order of an export. #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adriangl requested changes Nov 13, 2022
src/main/kotlin/com/hyperdevs/poeditor/gradle/PoEditorPlugin.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hyperdevs/poeditor/gradle/PoEditorPluginExtension.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hyperdevs/poeditor/gradle/PoEditorStringsImporter.kt Outdated Show resolved Hide resolved
src/main/kotlin/com/hyperdevs/poeditor/gradle/network/PoEditorApiController.kt Outdated Show resolved Hide resolved
WarrenFaith force-pushed the order_export branch from 0b1e964 to ee714c5 Compare | Hey, thanks for the feedback. I rebased to latest master and took the FilterType as a guidance. |
adriangl approved these changes Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR's key points
Added support to configure an order for the export.
How to review this PR?
Carefully please, I have never worked on a plugin project before. I am also not sure if there would be a meaningful test to be written.
Definition of Done
PS: would be cool to have this supported for the swift/iOS version too, but I am not capable of doing that...