Add unescapeHtmlTags flag and bump dependencies

[adriangl]

Github issue (delete if this does not apply)

Resolves #52

PR's key points

The PR adds a new flag to toggle HTML unescaping from strings.

Groovy

poEditor { apiToken = "your_api_token" projectId = 12345 defaultLang = "en" unescapeHtmlTags = false }

Kotlin

poEditor { apiToken = "your_api_token" projectId = 12345 defaultLang = "en" unescapeHtmlTags = false }

How to review this PR?

Check that the flag works as expected.

Definition of Done

• Changes summary added to CHANGELOG.md
• Documentation added to README.md (if a new feature is added)
• Tests added (if new code is added)
• There is no outcommented or debug code left

[adriangl]

Hi @apoi!

Sorry for the long delay! Could you please test that this version of the plugin works for your use case with the new flag?

classpath "com.github.hyperdevs-team:poeditor-android-gradle-plugin:feature~unescape-html-tags-flag-SNAPSHOT"

Thanks!

[apoi]

Hi @adriangl, thanks a lot for implementing this! I'm currently on holidays without access to the codebase so testing will be a bit delayed. I'll get back to this in about two weeks.

[adriangl]

Sure, no worries! Just let me know if it works when you can test it ;)

[apoi]

Thanks for your patience @adriangl, I was able to test the change now. The flag is recognized but doesn't change the output. Could it be because the unescaping is additionally done at file writing time, in Document.toAndroidXmlString()?

[adriangl]

Hi @apoi! Sorry for the late reply. Do you have any sample string that I can add to a PoEditor project to verify how the plug-in is behaving? Do the tests added at XmlPostProcessorTest.kt (lines 94 to 103) match your issue?

[keytronic]

Hello @apoi @adriangl do you have any update about this PR ?

I tested and changed the Document.toAndroidXmlString to add the unescapeHtmlTags flag and it's working as expected for me.

[justodepp]

Hello, any news about this feature coming on master?

[adriangl]

Hello, any news about this feature coming on master?

Hi @justodepp! Sorry for the delay, I've been trying to wrap my head around how to do this properly (I mean, the proposed solution by @keytronic would work, but I was trying to find a more elegant solution, maybe at XML level). I have to take a look at this, and if I don't find any proper solution, I'll leave the one mentioned in the comments.

[adriangl]

Hi @apoi, @keytronic, @justodepp! Can you test this version and verify that the new flag works as expected for your use cases? I've finally left the suggestion mentioned in the comments, as I didn't see any other way to do it, unfortunately.

classpath "com.github.hyperdevs-team:poeditor-android-gradle-plugin:f10ac7b094"