Fix CDATA strings losing CDATA string. Properly unescape HTML tags' symbols #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hi @mfathy and @awachowicz-futuremind! Could you please test that this version of the plugin works with your CDATA strings? implementation "com.github.hyperdevs-team:poeditor-android-gradle-plugin:bugfix~cdata-strings-SNAPSHOT"Thanks! |
This was referenced Sep 13, 2021
| Works great for me 👍 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Github issue (delete if this does not apply)
Resolves #44
Resolves #45
PR's key points
The PR fixes parsing for CDATA strings, as well as fixes some tags not getting parsed correctly by tweaking the
unescapeHtmlTagsmethod (suggested by @mfathy).How to review this PR?
Check that you can download CDATA strings from PoEditor and that its format is not lost
Definition of Done