Migrate to PoEditor API v2 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @nokite could you please test if the implementation works? I've tested it with a few projects of my own, but just in case: |
2 tasks
nokite approved these changes Jun 26, 2021
| | ||
| companion object { | ||
| /** Returns the enum value associated to a string value. */ | ||
| fun from(filterString: String) = valueOf(filterString.toUpperCase()) |
There was a problem hiding this comment.
Just as a reminder (it's probably OK) - it will throw an IllegalArgumentException if the specified name does not match any of the enum constants.
There was a problem hiding this comment.
Yeah, it's intended :P. It may be a bit overkill to add a typed exception just for the use case, I think the IllegalArgumentException should give enough feedback about what's happening (which should be an incorrect value from parameters, I hope)
Regardless, thanks for pointing it out!
adriangl force-pushed the task/poeditor-api-v2 branch from 0fd785f to 4c5e3ce Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Github issue
Resolves #39
PR's key points
The PR migrates the API from v1 to v2, basically. Some tweaks had to be added to support the new API, but nothing note-worthy.
How to review this PR?
Test that your projects can be downloaded successfully with the new plug-in version
Definition of Done