Skip to content

Conversation

@nokite
Copy link
Contributor

@nokite nokite commented Jun 25, 2021

PR's key points

Added local.properties to gitignore, as it contains machine-specific sdk.dir

How to review this PR?

The default comment in local.properties: "This file must NOT be checked into Version Control Systems"

Definition of Done

  • Tests added (if new code is added) - NA
  • There is no outcommented or debug code left
Copy link
Contributor

@adriangl adriangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@adriangl adriangl merged commit c7bb2e5 into hyperdevs-team:master Jun 25, 2021
@nokite nokite deleted the ignore-local-props branch July 5, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants