Skip to content

Conversation

@nokite
Copy link
Contributor

@nokite nokite commented Jun 24, 2021

PR's key points

Changed the xml encoding to lowercase "utf-8" which is more common.

How to review this PR?

Notice that other xml files in an Android project have the "utf-8" encoding in lowercase.

Definition of Done

  • Tests added (if new code is added) - does not apply
  • There is no outcommented or debug code left
Copy link
Contributor

@adriangl adriangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thanks a lot for the contribution @nokite!

I guess this change is just an aesthetic change to ensure XML consistency over all the Android XML files, right? Or did you run into any kind of issues? Anyway, looks good to me!

Just one thing though, could you please add the change in CHANGELOG.md so we can keep track of changes for the next release?

@nokite
Copy link
Contributor Author

nokite commented Jun 26, 2021

First of all, thanks a lot for the contribution @nokite!

I guess this change is just an aesthetic change to ensure XML consistency over all the Android XML files, right? Or did you run into any kind of issues? Anyway, looks good to me!

Just one thing though, could you please add the change in CHANGELOG.md so we can keep track of changes for the next release?

Yes, I believe it's purely an aesthetic change indeed, I didn't see any actual problems.

Sure, added!

@adriangl adriangl merged commit 697089d into hyperdevs-team:master Jul 4, 2021
@nokite nokite deleted the xml-encoding branch July 5, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants