Skip to content

Refactoring to use the hk_double_from_chars to implement the compiler parse_double function. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Refactoring to use the hk_double_from_chars to implement the compiler parse_double function. #30

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
43af42e
Refactoring the compiler's parse_double function to use the utils hk_…
agaro Feb 16, 2023
88a095e
Merge branch 'fabiosvm:main' into main
agaro Feb 16, 2023
f8beeca
Removing unnecessary errno attribution
agaro Feb 16, 2023
aaaec73
Merge branch 'main' of github.com:agaro/hook-lang
agaro Feb 16, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/hk_compiler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include "hk_scanner.h"
#include "hk_struct.h"
#include "hk_builtin.h"
#include "hk_utils.h"

#define MAX_CONSTANTS UINT8_MAX
#define MAX_VARIABLES UINT8_MAX
Expand Down Expand Up @@ -174,9 +175,8 @@ static inline double parse_double(compiler_t *comp)
{
scanner_t *scan = comp->scan;
token_t *tk = &scan->token;
errno = 0;
double result = strtod(tk->start, NULL);
if (errno == ERANGE)
double result;
if (!hk_double_from_chars(&result, tk->start))
syntax_error(comp->fn->name, scan->file->chars, tk->line, tk->col,
"floating point number `%.*s` out of range", tk->length, tk->start);
return result;
Expand Down