This repository was archived by the owner on Mar 7, 2025. It is now read-only.
fix: added ruby sass dependency #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
With how the docker-compose is, everything seems to work fine until you touch the css. Then you get error
webassets.exceptions.FilterError: Program file not found: sass.This commit fixes that by installing sass through the Dockerfile. I don't believe the worker needs this, hence it's only in the Dockerfile for the server.
PS: I had a merged PR in October, that dealt with making the docker-compose work out of the box, this is the second error I encountered during my journey, that I never got around to open a PR for.