This repository was archived by the owner on Mar 7, 2025. It is now read-only.
Properly use the default parameter of get() #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Using `dict.get('key') or True` means that key can never be False! And in other cases, it's just clearer and more compact to use the default parameter. Contributor Author
| Checks green now. :-) |
Contributor
| Looks good to me. Merging :) |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Using
dict.get('key') or Truemeans that key can never be False! Andin other cases, it's just clearer and more compact to use the default
parameter.
I ran into this when I was trying to disable TLS so I could use the Python SMTPd for debugging mail. TLS was always on, even when I set
MAIL_USE_TLS=in the config.env file. I eventually discovered that it was because that was turning into a True value after processing the file.Note that the behavior has also changed for
SSL_DISABLE, which is being compared to the string 'True'. If it was left blank asSSL_DISABLE=, then it would turn into True. Now it will register an empty string in the .env file as False.