Skip to content

Prevent to add PageInfo definition if not needed #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2021
Merged

Prevent to add PageInfo definition if not needed #476

merged 2 commits into from
Mar 4, 2021

Conversation

@ooga
Copy link
Contributor

@ooga ooga commented Jan 20, 2021

Checklist

  • Pull requests follows the contribution guide
  • New or modified functionality is covered by tests

Description

Prevent RelayConnectionFactory to do extra work and add new definition when not needed.
@oryan-block
Copy link
Collaborator

Can you provide an example schema where this is a problem?
I'm not sure I understand what we're trying to solve here.
@vojtapol
Copy link
Member

I believe the problem is that we are always adding some baked-in types to facilitate the relay @connection directive. If the users want to have their own type called PageInfo for whatever reason they can't because it clashes.
vojtapol
vojtapol requested changes Feb 26, 2021
View reviewed changes
Copy link
Member

@vojtapol vojtapol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
@ooga ooga force-pushed the not-add-pageinfo-definition branch from ff0e12b to fabdb3d Compare March 4, 2021 16:48
@ooga ooga requested a review from vojtapol March 4, 2021 16:49
@vojtapol vojtapol merged commit 576353e into graphql-java-kickstart:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@ooga @oryan-block @vojtapol