Resolves #383: Added a search in FieldResolverScanner for getters where the field name needs to be converted from snake to camel case. #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… getters where the field name needs to be converted from snake to camel case.
Contributor Author
| @oliemansm Would love to get a review for this and have it in the next build if possible. Feedback is welcome of course. |
oryan-block approved these changes Jan 8, 2021
Collaborator
oryan-block left a comment
oryan-block left a comment There was a problem hiding this comment.
LGTM 👍
I replaced the apache utils calls with standard kotlin string manipulation.
vojtapol approved these changes Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added a search in FieldResolverScanner for getters where the field name needs to be converted from snake to camel case.
Resolves #383
Checklist
Description
The findResolverMethod function has a cascading if/else check to try to find a matching method in a variety of formats. I added a 5th check (similar to the 3rd check) but instead of only capitalizing the fieldname I converted the fieldname from snake case to camelCase. The existing code uses Apache Commons-lang3 already, so I stayed with it to do the snake to camel case conversion. Ideally I would have preferred to use CaseFormat from Guava or CaseUtils from Apache Commons Text, but I did not want to introduce a new dependency.