Upgrade to graphql-java 16.1 #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 6 commits December 1, 2020 20:41
…code that checks if the @uppercase directive is applied correctly.
Contributor Author
| @vojtapol or @oliemansm, any feedback on this pull request? Is it acceptable for migration to graphql-jave 16.1? |
Member
| @lburja We want to make one last release on |
Contributor Author
| That’s fine with me, it makes sense! … On 8 Dec 2020, at 16:10, Vojtech Polivka ***@***.***> wrote: @lburja We want to make one last release on graphql-java 15.0 with all the recent bug fixes for people that are not ready to upgrade to graphql-java 16.0. Then we will merge this. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. |
oryan-block approved these changes Dec 24, 2020
Collaborator
There was a problem hiding this comment.
Looks good overall.
Some noteworthy changes from that releaase:
- Use of immutable collections may break some things when upgrading but should be easy to fix.
- We'll probably need to do some work to support repeatable directives as well.
| // directiveDefOpt = FpKit.findOne ...) | ||
| // Note 2: repeatable directives (new feature in graphql-java 16) likely don't work, | ||
| // since we don't pass in the full set of discovered directives | ||
| return super.buildDirective(null, directive, setOf(graphQLDirective), directiveLocation, comparatorRegistry) |
Collaborator
There was a problem hiding this comment.
Just going to note that this was made package protected in this PR: graphql-java/graphql-java#2058
I don't like this solution but it will do for now.
We may want to consider reflection for a more permanent solution.
vojtapol approved these changes Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #457
Checklist
Description
Upgrade graphql-java library to 16.1, and fix issues
All tests pass, and the library seems to work fine on some internal projects that I have