Fix regression: if null is passed as parameter to a resolver method, … #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…use Java default value
Contributor Author
| @vojtapol, could you please take a look at this pull request? It basically reverts a condition to what it was one month ago, and adds a unit test for the bug. |
Member
| Yup. As soon as I can. |
Member
| @alexandreBaronZnk Could you please review this PR as well? It seems that #453 brought in this bug. I just want to make sure this change does not break your original use case. |
alexandreBaronZnk approved these changes Dec 8, 2020
Contributor
alexandreBaronZnk left a comment
alexandreBaronZnk left a comment There was a problem hiding this comment.
Looks good to me. Thanks @lburja for the fix.
vojtapol approved these changes Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…use Java default value
Fixes #461
Checklist
Description
Fixed MethodFieldResolver class, where a regression was introduced as part of some recent commits.
I've added a unit test that demonstrates the expected behavior