Upgrade kotlin and kotlin-coroutines to versions 1.3.72 and 1.3.9 #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The CoroutineScope.publish(...) method was deprecated in favour of the global publish(...) method. See Publish.kt in kotlinx-coroutines-reactive lib.
vojtapol requested changes Sep 8, 2020
src/test/groovy/graphql/kickstart/tools/SchemaParserSpec.groovy Outdated Show resolved Hide resolved
| Looks good to my eyes. Had a quick test run with it and passes our integration tests. |
| @vojtapol Hi, is it possible to get any progress with this PR? |
vojtapol approved these changes Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #378
Checklist
Description
Replaced deprecated CoroutineScope.publish(...) with top-level publish(...) method in SchemaParserOptions(See: https://github.com/Kotlin/kotlinx.coroutines/blob/master/reactive/kotlinx-coroutines-reactive/src/Publish.kt). No new tests were added but existing ones looked sufficient to me. I noticed that @oliemansm didn't upgrade the kotlin-coroutines lib in the "upgrade-dependencies" branch (See: commit 4543ccd) so there might be a reason to not do this update that I am not aware of?!