Add streaming key to the requests #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
itsmylife changed the title 
zoltanbedi previously approved these changes Sep 1, 2025
src/datasource.ts Outdated
| }) | ||
| ); | ||
| | ||
| // const ds = this; |
zoltanbedi approved these changes Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What is this?
In this PR each request has a unique streaming key with
orgIdto identify the organizations. So different organizations will have separate streams. On the frontend we generate and send that key and on the backend we use it to store the topic and use orgID provided. If the orgID is different than the plugin configuration this will return an error and subscribing to the stream will be failed.The idea was taken from
How to test?
mage -vyarn devyarn brokermillisecond/1000and see in developer tools it's sending a streaming key with orgID.