Skip to content

Conversation

@func25
Copy link
Contributor

@func25 func25 commented Sep 6, 2024

Fixes #69303

@gopherbot
Copy link
Contributor

This PR (HEAD: a5d106a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611300.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-06T04:51:55Z","revision":"45dce056f9c76f4cce923b491a39ead55454963b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@func25 func25 changed the title regexp/syntax: fix >10000x slower Regexp.String() regexp/syntax: Optimize calcFlags() for OpCharClass fold case Sep 6, 2024
@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: d73ed17) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611300.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 3:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@func25 func25 changed the title regexp/syntax: Optimize calcFlags() for OpCharClass fold case regexp/syntax: optimize OpCharClass fold case in calcFlags Sep 6, 2024
@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 4:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: fde0243) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611300.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 6:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cuong Manh Le:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 4a3c198) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611300.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

Message from Phuong Le (Aiden):

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/611300.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants