Skip to content

all: merge flag* const info internal/reflectlite #64908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

all: merge flag* const info internal/reflectlite #64908

wants to merge 18 commits into from
+486 −517

Conversation

@qiulaidongfeng
Copy link
Member

@qiulaidongfeng qiulaidongfeng commented Dec 31, 2023

For #59670
@gopherbot
Copy link
Contributor

gopherbot commented Dec 31, 2023

This PR (HEAD: 2cd9a57) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Dec 31, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from qiulaidongfeng:

Patch Set 1: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 1: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

This PR (HEAD: d531f0c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from qiulaidongfeng:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 6, 2024

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 27, 2024

This PR (HEAD: 0dbe9cf) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Jan 27, 2024

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 27, 2024

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 27, 2024

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 27, 2024

Message from qiulaidongfeng:

Patch Set 3: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 30, 2024

Message from qiulaidongfeng:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 30, 2024

Message from Keith Randall:

Patch Set 3:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

This PR (HEAD: 0c781f7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

This PR (HEAD: 4c2c7d6) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from qiulaidongfeng:

Patch Set 5: Run-TryBot+1

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from Gopher Robot:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from Gopher Robot:

Patch Set 5: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

This PR (HEAD: 6875809) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from qiulaidongfeng:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Jan 31, 2024

Message from Gopher Robot:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@qiulaidongfeng qiulaidongfeng changed the title all: merge flag* const info internal/abi all: merge flag* const info internal/reflectlite Jan 31, 2024
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 13: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from qiulaidongfeng:

Patch Set 14: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 14:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 14:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 14: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@qiulaidongfeng
n
1fd0739 
Change-Id: I78354489ef5e7e470919b11c8315a7ed912bd301
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

This PR (HEAD: 1fd0739) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from qiulaidongfeng:

Patch Set 15: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 15:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 15: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@qiulaidongfeng
n
02602cd 
Change-Id: I3599a93680c0c9149cd9c3360e4f75ffda2abe91
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

This PR (HEAD: 02602cd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from qiulaidongfeng:

Patch Set 16: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 16:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 16: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@qiulaidongfeng
n
3308d7e 
Change-Id: Id138dcd2c103517f9a25afa1cd2a18ad14c2a65a
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

This PR (HEAD: 3308d7e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/552376.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from qiulaidongfeng:

Patch Set 17: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 17:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from Gopher Robot:

Patch Set 17: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 17, 2024

Message from qiulaidongfeng:

Patch Set 17: -Run-TryBot

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 19, 2024

Message from Keith Randall:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from qiulaidongfeng:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from Keith Randall:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from qiulaidongfeng:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from Keith Randall:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from qiulaidongfeng:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
@gopherbot
Copy link
Contributor

gopherbot commented Feb 20, 2024

Message from Keith Randall:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/552376.
After addressing review feedback, remember to publish your drafts!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@qiulaidongfeng @gopherbot