Fixing error with unallowed commands

[fe-lix-]

When running this to test the ssh connectivity, I found this bug:

-> % ssh git@gitlab ls /home/git/gitlab-shell/lib/gitlab_shell.rb:102:in `join': can't convert nil into String (TypeError) from /home/git/gitlab-shell/lib/gitlab_shell.rb:102:in `escape_path' from /home/git/gitlab-shell/lib/gitlab_shell.rb:57:in `parse_cmd' from /home/git/gitlab-shell/lib/gitlab_shell.rb:22:in `exec' from /home/git/gitlab-shell/bin/gitlab-shell:16:in `<main>' 

The expected behaviour would be :

-> % ssh git@gitlab ls Not allowed command 

Excuse me for my ruby style, I am not used to this language.

[coveralls]

Coverage decreased (-0.01%) when pulling 906b97e on fe-lix-:master into 56e216f on gitlabhq:master.

[coveralls]

Coverage increased (+0.06%) when pulling 8aa0864 on fe-lix-:master into 56e216f on gitlabhq:master.

[fe-lix-]

Found the real problem to be that it crashed only on one word command arbitrary would crash but arbitrary command would pass. I have updated the test with a one word command example.

[MrKeiKun]

BUMP
👍

same here

/home/git/gitlab-shell/lib/gitlab_projects.rb:23:in `join': no implicit conversion of nil into String (TypeError) from /home/git/gitlab-shell/lib/gitlab_projects.rb:23:in `initialize' from ./gitlab-projects:25:in `new' from ./gitlab-projects:25:in `<main>' 

[dpursehouse]

👍

Just found the same problem.

[MrKeiKun]

Bump~

[dzaporozhets]

In this case we need to add some check here - https://github.com/gitlabhq/gitlab-shell/blob/master/lib/gitlab_shell.rb#L52 to prevent actions with empty repo name