Skip to content

Conversation

@Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 23, 2017

No description provided.

@willdurand willdurand requested a review from toin0u June 23, 2017 07:02
@Nyholm Nyholm changed the title Fixed broken build on HHVM Fixed broken build on master Jun 23, 2017
(Lets move away for Googles DNS)
@mikebronner
Copy link
Member

Quick question: why is using Time Warner better than Google DNS? The idea what to use a stable IP address that is commonly known and used to better guarantee the test result.

I'll go ahead and merge this in and tweak composer.json a bit (some of the requirements need to stay the way they were). At the same time I'll do what I can to get TravisCI to pass that 3rd test. Was going to look at travis build process this weekend anyway, since now it seems to handle PHP 7.

@mikebronner mikebronner merged commit 8be0cb2 into master Jun 23, 2017
@mikebronner mikebronner deleted the Nyholm-patch-1 branch June 23, 2017 14:59
@mikebronner mikebronner removed the request for review from toin0u June 23, 2017 14:59
@Nyholm
Copy link
Member Author

Nyholm commented Jun 23, 2017

I tried to fix the broken build. That is why I changed the IP. But none seams to resolve. Maybe we should add cached responses here so we do not actually have to do a lookup when running the tests.

The test works for me locally but fails on Travis.

@mikebronner
Copy link
Member

Yea, its an issue with Travis not resolving the cert chain for FreeGeoIP. Fixed now. See #51 :) We're all green again. Woot! When I initially opened the issue back then, it wasn't resolving any of the providers, so I didn't look at it since (and set up my own build server, which was more reliable). This was on my to-do list for this weekend anyway, since I read last week about PHP7 and external services properly resolving now. Thanks for putting this in. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants