Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Conversation

@oxyc
Copy link
Collaborator

@oxyc oxyc commented Mar 2, 2016

Initial stab att PostgreSQL support #146. I've never used it before so I'll need some help here.

There's quite a bit of todos here

  • @geerlingguy we need a php-pgsql role.
  • Figure out exactly why the php role always gets skipped when php-mysql is skipped.
  • Dashboard needs a lot of work. Might need to re-structure database connections a bit as someone could use both pgsql and mysql.
  • What's the deal with admin/root login (mysql root login). No pass?
  • Docs
  • Figure out if there are any other settings we need to configure (and document)
  • Get tests to pass
  • Remove travis tests once this is RTBC
@oxyc oxyc force-pushed the postgresql branch 3 times, most recently from b84fb6e to 9add9f5 Compare March 2, 2016 04:08
@oxyc oxyc changed the title Support PostgreSQL [WIP] Support PostgreSQL Mar 2, 2016
@oxyc oxyc force-pushed the postgresql branch 4 times, most recently from 0a92a9d to 64c79ba Compare March 2, 2016 15:36
@oxyc
Copy link
Collaborator Author

oxyc commented Mar 2, 2016

  • In the dashboard I set the root postgresql password to Passwordless but I guess this can be changed in the postgresql role somehow. I just dont know how. Anyone with experience who knows how we should do this? Maybe this is good enough for now as it's the default.
  • @geerlingguy do you want to separate the php-pgsql installation into a separate role?
  • Anyone with PostgreSQL experience who can review this. I have no clue what I'm doing :) It works at least
  • @geerlingguy how do you feel about the backwards_compatibility.yml task I added? I prefer this over cluttering all variable references with a default filter at least. My idea is that we leave this in for a while before finally removing it.

screen shot 2016-03-02 at 11 10 39

php_xhprof_html_dir: "/usr/share/php/xhprof_html"
when: php_xhprof_html_dir is not defined

- name: Install PHP PostgreSQL dependencies.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd like to follow the pattern of setting this up in a separate role. Will try to get to that soon.

@oxyc
Copy link
Collaborator Author

oxyc commented Mar 3, 2016

@geerlingguy here's a quick patch you can use on top of the php-mysql role (I'm not a reliable maintainer) oxyc/ansible-role-php-pgsql@9445030

Maybe better to name everything postgresql instead of pgsql... Reason I'm keeping to pgsql is because of the database uri schema for drush. Maybe I'm just making it even more confusing though

@oxyc oxyc force-pushed the postgresql branch 2 times, most recently from 01f98b7 to e4bd913 Compare March 3, 2016 03:48
@oxyc
Copy link
Collaborator Author

oxyc commented Mar 3, 2016

I also adressed your 2 suggestions. If we keep them we also need to either remove backwards_compitability.yml or add the variable name changes for drupal_mysql_*. Feels like it's better to just do a major version bump and exclude it.

@geerlingguy
Copy link
Owner

Version bump++

I'll do one more minor release before merging in these changes, then we can work on a couple other changes for a 3.0

@oxyc
Copy link
Collaborator Author

oxyc commented Mar 3, 2016

I removed the backwards_compitabilty.yml. Do you want me to keep one of the travis builds to verify we dont break it? Could minimise the build time by removing a few extra installs such as pimpmylog, varnish, memcached etc.

@geerlingguy
Copy link
Owner

I'd keep one build - remove all the extra installs so we're just testing the one thing.

@geerlingguy geerlingguy added this to the 3.0.0 milestone Mar 5, 2016
@geerlingguy geerlingguy removed this from the 3.0.0 milestone May 13, 2016
@geerlingguy
Copy link
Owner

I removed the 3.0.0 milestone; don't want this to hold up that release.

@geerlingguy
Copy link
Owner

@oxyc - As with all branches that sit too long... I couldn't pick up from here easily, so I started a separate branch. Thanks for your awesome work on this, and I hope you're having a great time traveling right now :)

Moving further discussion over to the original issue, #146

@geerlingguy geerlingguy closed this Oct 1, 2016
@oxyc oxyc deleted the postgresql branch April 25, 2017 00:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants