Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

Conversation

@arknoll
Copy link
Contributor

@arknoll arknoll commented Jul 9, 2015

Relates to #137

Notes/TODOs from @geerlingguy:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated (upstream) to a variable with the name of the role prefixed (e.g. selenium_server_version)? Similar to Drupal modules, it's best to use a prefixed variable name so there are no conflicts between roles (and to clarify what, exactly, the variable is used for in a large config file).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like the variable is selenium_version upstream... is that correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it should have been selenium_version. Fixed.

@geerlingguy
Copy link
Owner

One other question: Would you be willing to (or would you accept a PR from me to) make arknoll.selenium work on RHEL/CentOS? Currently all other configuration in the VM works across platforms, so people can switch to other base boxes if they would like, and I don't want to take away that ability if they want to use selenium.

@arknoll
Copy link
Contributor Author

arknoll commented Jul 9, 2015

@geerlingguy let me give it a shot to get it working on RHEL/CentOS.

@geerlingguy
Copy link
Owner

@arknoll - Great! let me know when that's done, and I'll un-postpone this PR.

@geerlingguy geerlingguy changed the title Add selenium and firefox to vm. Add selenium and firefox to vm to power Behat tests Jul 10, 2015
@geerlingguy geerlingguy changed the title Add selenium and firefox to vm to power Behat tests Add Selenium and Firefox to vm to power Behat tests Jul 10, 2015
@arknoll
Copy link
Contributor Author

arknoll commented Jul 10, 2015

@geerlingguy
Copy link
Owner

Great! I'll merge and do some more testing tonight.

geerlingguy added a commit that referenced this pull request Jul 11, 2015
PR #161: Add Selenium and Firefox to power Behat tests.
@geerlingguy geerlingguy merged commit 580d0ce into geerlingguy:master Jul 11, 2015
@geerlingguy
Copy link
Owner

Verified that behat/selenium/firefox/etc. works great across all supported CentOS and Ubuntu versions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

2 participants