-
- Notifications
You must be signed in to change notification settings - Fork 634
Issue #1092: Docs makeover #1088
Conversation
| If interested, maybe we can try and define the docs outline in an issue. |
| Let's do that—rather than jump around a bit in RTD. I do think we could organize docs better... and RTD does get quite annoying—but it's free, connected to GitHub, searchable (thanks to your help), etc. so it's the best of what we have available for zero maintenance cost :) You know that of course, but just documenting my reasons for still using it. |
| Still WIP and needs work. I just need to go do something else after staring at this for too long. I'll continue tomorrow. Sorry about the massive commit, energy ran out and I just wanted to push something. If you prefer I can try and split it into parts. Let me know what you think, I don't mind re-structuring. Edit: Oh and I reverted the numbering, it was buggy... default is probably good enough |
| @@ -0,0 +1,11 @@ | |||
| ## Improving composer build performance | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this section because
- I split the composer deployment setups into separate pages and linked both to this page.
- Thought we might extend it in the future.
Might be other performance related stuff in the docs that could be moved here also. I'll have a look tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it would be good to also at least point people to notes on Windows performance, NFS/rsync/native share performance, how to adjust memory limits (for VM and php especially), etc. Also, cachier, things like that. Simple is best, but anything that people might not ordinarily know about would be good to document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll move those sections here too. Cleans up the windows installation section which is a bit too crowded at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved a couple of scattered performance sections here instead.
| @@ -0,0 +1,3 @@ | |||
| If you have `adminer` listed as one of the `installed_extras` inside `config.yml`, you can use Adminer's web-based interface to interact with databases. With Drupal VM running, visit [http://adminer.drupalvm.dev/](http://adminer.drupalvm.dev/), and log in with `drupal` as the username and the password you set in `config.yml` (`drupal_db_password`). Leave the "Server" field blank. The "Database" field is optional. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a duplicate with Connect to the MySQL database, but i feel the paragraph isnt long enough to justify a reference, and I do think it's important it's mentioned in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable.
| | ||
| ```php | ||
| // Make memcache the default cache class. | ||
| $settings['cache']['default'] = 'cache.backend.memcache'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't actually tested this in a while, but I'm pretty sure this is how it was supposed to be configured..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct. The README for the 8.x-2.x branch is still a bit outdated for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that both this and the redis docs work.
docs/extras/redis.md Outdated
| @@ -0,0 +1,5 @@ | |||
| [Redis](https://redis.io/) is an in-memory caching system, much like [Memcached](memcached.md). While [Varnish](varnish.md) is generally used to improve performance for anonymous users, `redis` is used to improve the performance for logged in users. | |||
| | |||
| To enable Redis in Drupal VM, first make sure `redis` is in the list of `installed_extras` in your `config.yml`. Install the [Redis](https://www.drupal.org/project/redis) module and configure it as described in the [module's README](http://cgit.drupalcode.org/redis/tree/README.md). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I felt something is better than nothing. But would be great if we could elaborate on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done much Redis testing in the past 6 months. I'm fine with this as-is, and we can update it once someone actually starts playing around with Redis some more :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to test this and memcached to make sure we have some basic docs. Not sure I'll have time to fix everything until the weekend though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, you're awesome! I'll hold off on the merge, then—unless you want me to merge now, then we can just review the changes/cleanups in a follow-up PR. I'd like to tag a new release soon, since there are a few small bugs fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind holding off or tagging a new release without this? I'd like to read through everything at least once more.
| | ||
| To enable profiling of Drupal pages using the Tideways PHP Extension, follow the directions for [configuring the XHProf and the XHProf module](xhprof.md#xhprof-module), but choose the _Tideways_ extension under in the _Profiling settings_ section. | ||
| | ||
| As with the XHProf extension, you can view callgraphs (and a listing of all stored runs) using Drupal VM's own XHProf UI installation by visiting [http://xhprof.drupalvm.dev/](http://xhprof.drupalvm.dev) and clicking on the relevant run, then clicking the _[View Full Callgraph]_ link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geerlingguy I added a note on the XHProf UI working with Tideways as well.
| - 'upload-progress': 'extras/upload-progress.md' | ||
| - 'varnish <small>(Caching reverse proxy)</small>': 'extras/varnish.md' | ||
| - 'xdebug <small>(Debugging tool)</small>': 'extras/xdebug.md' | ||
| - 'xhprof <small>(Profiling tool)</small>': 'extras/xhprof.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personal styling preference, this makes the name stand out while still explaining what it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with that, as long as RTD isn't barfing on it.
| - 'mailhog <small>(Mail catcher)</small>': 'extras/mailhog.md' | ||
| - 'memcached <small>(In-memory cache)</small>': 'extras/memcached.md' | ||
| - 'newrelic <small>(Performance monitoring)</small>': 'extras/newrelic.md' | ||
| - 'nodejs': 'extras/nodejs.md' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't come up with a short description for java, nodejs, ruby or upload-progress :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal... they're pretty self-explanatory (IMO).
| Sure; we can do a bugfix release, then next tag could be docs release :) |
| I'm sure there are more typos and grammar errors... But I've read through everything at least 3 times now. |
| drupalvm_cron_jobs: | ||
| - name: "Drupal Cron" | ||
| minute: "*/30" | ||
| job: "{{ drush_path }} -r {{ drupal_core_path }} core-cron" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fixes #1027
| Let's do it! |
I'm just toying around with a new docs TOC. I feel it's getting a bit chaotic... Not sure how to section it though... Thoughts? Is it needed or no? I also added numbering to the TOC (omg readthedocs has a lot of bugs).