Skip to content

Conversation

@brettz9
Copy link
Collaborator

@brettz9 brettz9 commented Oct 26, 2025

fix(CJS): provide CJS version of to-valid-identiifer; fixes #1583

@brettz9 brettz9 requested a review from Copilot October 26, 2025 15:44
@brettz9 brettz9 added the bug label Oct 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for providing a CJS (CommonJS) version of the to-valid-identifier dependency, which is an ESM-only package. The solution uses Rollup to bundle the ESM package into a CJS format during the build process.

  • Introduces Rollup configuration to transpile to-valid-identifier from ESM to CJS
  • Updates build script to generate and use the CJS bundle
  • Removes escape-string-regexp from the dependency rejection list

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
rollup.config.js New Rollup configuration to bundle to-valid-identifier as CJS
package.json Adds Rollup dependencies and integrates bundling into build process
.ncurc.cjs Removes outdated comment about escape-string-regexp conversion
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@brettz9 brettz9 merged commit ca57a1f into gajus:main Oct 26, 2025
5 checks passed
@github-actions
Copy link

🎉 This PR is included in version 61.1.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brettz9 brettz9 deleted the to-valid-identifier branch October 26, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant