Skip to content

Conversation

@TheJaredWilcurt
Copy link

@TheJaredWilcurt TheJaredWilcurt commented Oct 13, 2025

Closes #1568

Improve example code to show @callback solution, and better differentiate variable names for clarity.

Improve example code to show `@callback` solution, and better differentiate variable names for clarity.
@brettz9
Copy link
Collaborator

brettz9 commented Oct 13, 2025

Thanks for the PR! The docs though are generated from the .README templates and then supplied with—as is relevant for your changes—the tests in the test/rules/assertions folder. We'd need changes done in the tests file instead, and then run pnpm create-docs to update the generated files.

@TheJaredWilcurt
Copy link
Author

I'll let you do that, pnpm only has experimental support by Volta, and I'd rather not mess with my environment for all my other repos to try to get this repo to work for a single PR. If it just used regular Node/npm then I'd give it a try, but I've gone years at this point without seeing a Yarn or pnpm repo, so I don't think it's worth it to mess with that for me.

@TheJaredWilcurt TheJaredWilcurt deleted the patch-1 branch October 13, 2025 22:08
@brettz9
Copy link
Collaborator

brettz9 commented Oct 14, 2025

I'll let you do that, pnpm only has experimental support by Volta, and I'd rather not mess with my environment for all my other repos to try to get this repo to work for a single PR. If it just used regular Node/npm then I'd give it a try, but I've gone years at this point without seeing a Yarn or pnpm repo, so I don't think it's worth it to mess with that for me.

Sure, done. If you value disk space and create a lot of repos, you're missing out on pnpm though. I couldn't fit all the repos I have on my machine if I weren't using pnpm for most of them. Hopefully Volta support will be upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants