Skip to content

Conversation

@simllll
Copy link
Contributor

@simllll simllll commented Jan 26, 2020

fixes #23

@simllll
Copy link
Contributor Author

simllll commented Jan 26, 2020

there is one more issue with this: <!--eslint-disable-next-line vue-scoped-css/require-scoped-->
gets ignored. I will have another look tonight.

@simllll
Copy link
Contributor Author

simllll commented Jan 26, 2020

Alright, I was looking intot the problem why the comment line does not disable the eslint rule. But as it turns out, this is not an issue to this fix, it's a more generic one that can be solved/worked arround by moving the disable comment into the script part.
e.g.

<script> /* eslint-disable vue-scoped-css/require-scoped */ </script> <style> .unscoped-style { .. } </style>

I linted the file now too. For me the problem is solved, even though it would be even nicer if the comment can be done in html block, but not really doable with the current approach I would say and adding something like this to doc would be probably the best way of achieving the same.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@ota-meshi ota-meshi merged commit df5dd86 into future-architect:master Jan 27, 2020
@ota-meshi
Copy link
Member

ota-meshi commented Jan 27, 2020

Hi @simllll. <!-- eslint-disable --> can only be used inside <template>.
https://eslint.vuejs.org/rules/comment-directive.html

You have to write /* eslint-disable */ in the <script> block as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants