-
- Notifications
You must be signed in to change notification settings - Fork 13
feat(enforce-style-type): new rule #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(enforce-style-type): new rule #102
Conversation
| Thank you for this PR! I forgot that this rule had the I think it's a bit confusing for the next test case to report an error. { code: ` <template> </template> <style module> </style> `, options: [ "never", { acceptCssModules: true, }, ], }I think the
I don't use SFC with CSS modules, so I'm not familiar with it. |
| Thank you @ota-meshi I'll update the PR to have the |
| Sorry for the wait! Ready for review again |
| I'm working on the docs now, and I'm curious what you think about making this a new rule Making it a separate rule and deprecating |
| I think it makes sense to deprecate the require-scoped rule and add an enforce-style-type rule. The current rule name has been confused by the addition of options. |
| Alright! I think it's ready for another review. Feeling pretty good about this one. Also, if there's a deprecation method you have for |
ota-meshi left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for lot of work!
| Thank you for your contribution!
I noticed that this plugin doesn't have a deprecation rule yet. The script may not be in place yet. I will do that work. |
| Thank you so much @ota-meshi ! Pleasure to contribute. |
Closes #101
I ended up naming it
acceptCssModulesinstead ofacceptModulebecause the name is actually plural "CSS Modules".Thank you
I'm also curious if you'd be open to requiring scoping via CSS Modules as well. So instead of
acceptCssModules, we do:where:
undefined: Don't acknowledgemoduleaccept: Acceptmodulein-place ofscoperequire: Require scoping viamoduleinstead ofscopeApr 26 Update:
Implemented the following:
May 20 Update:
Implementing the following:
May 21 Update:
Moved to new rule
enforce-style-type