Skip to content

Revert "feat: dynamic import of socketio client" #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Revert "feat: dynamic import of socketio client" #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions source/event_hub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// :copyright: Copyright (c) 2016 ftrack
import { v4 as uuidV4 } from "uuid";
import loglevel from "loglevel";
import io from "./simple_socketio.js";
import { Event } from "./event.js";
import {
EventServerConnectionTimeoutError,
Expand All @@ -9,7 +10,7 @@ import {
NotUniqueError,
} from "./error.js";
import { Data } from "./types.js";
import type io from "./simple_socketio.js";

interface BaseActionData {
selection: Array<{
entityId: string;
Expand Down Expand Up @@ -177,9 +178,7 @@ export class EventHub {
}

/** Connect to the event server. */
async connect(): Promise<void> {
const simple_socketio = await import("./simple_socketio.js");
const io = simple_socketio.default;
connect(): void {
this._socketIo = io.connect(this._serverUrl, this._apiUser, this._apiKey);
this._socketIo.on("connect", this._onSocketConnected);
this._socketIo.on("ftrack.event", this._handle);
Expand Down