Skip to content

fix: Single-part uploads not retried when request fails #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

fix: Single-part uploads not retried when request fails #122

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16c4fbd
fix: Single-part uploads not retried when request fails
lucaas Jun 13, 2023
8408934
Do not call abort for single-part uploads
lucaas Jun 13, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source/uploader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,11 @@ export class Uploader {
});
logger.debug("Upload complete", this.componentId);
} catch (error) {
try {
await this.cleanup();
} catch (cleanupError) {
logger.error("Clean up failed", cleanupError);
}
if (this.onError) {
this.onError(error as Error);
}
Expand Down Expand Up @@ -464,16 +469,15 @@ export class Uploader {
);
this.xhr.open("PUT", url, true);
this.xhr.onabort = async () => {
this.aborted = true;
if (this.onAborted) {
this.onAborted();
}
await this.cleanup();
reject(
new CreateComponentError("Upload aborted by client", "UPLOAD_ABORTED")
);
};
this.xhr.onerror = async () => {
await this.cleanup();
reject(
new CreateComponentError(`Failed to upload file: ${this.xhr!.status}`)
);
Expand Down