- Notifications
You must be signed in to change notification settings - Fork 196
feat: extend intrinsic matmul #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wassup05 wants to merge 30 commits into fortran-lang:master Choose a base branch from wassup05:matmul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
30 commits Select commit Hold shift + click to select a range
f06f556 add interface and procedures
wassup05 fed4d73 add implementation for 3,4,5 matrices
wassup05 27911ae add very basic example
wassup05 a7f645c fix typo
wassup05 cc77dee a bit efficient
wassup05 3958018 refactor algorithm
wassup05 35a5a28 add new interface
wassup05 ebf92d7 add helper functions
wassup05 5f5c5a9 add implementation, refactor select to if clauses
wassup05 06ce735 slightly better examples
wassup05 e709f83 replace all matmul's by gemm
wassup05 cf5f030 add error handling in a better way
wassup05 b6d07e6 Update src/stdlib_intrinsics_matmul.fypp
perazz 5e3b588 Update src/stdlib_intrinsics_matmul.fypp
perazz 7d2130a Update src/stdlib_intrinsics_matmul.fypp
perazz 61851fc Update src/stdlib_intrinsics_matmul.fypp
perazz ee7da8d Update src/stdlib_intrinsics_matmul.fypp
perazz 195c57e Update src/stdlib_intrinsics_matmul.fypp
perazz e71b9bb Update src/stdlib_intrinsics_matmul.fypp
perazz 00c4461 Update src/stdlib_intrinsics_matmul.fypp
perazz 5c2bbc5 Update src/stdlib_intrinsics_matmul.fypp
perazz 79113da Update src/stdlib_intrinsics_matmul.fypp
perazz 72dc641 added specs
wassup05 cee5bba added tests
wassup05 a052599 modified example and slight changes
wassup05 24c5787 Merge branch 'fortran-lang:master' into matmul
wassup05 0174145 Merge branch 'master' of github.com:wassup05/stdlib into matmul
wassup05 2d0d9ca reduce size, increase tolerance
wassup05 ca3e470 Merge remote-tracking branch 'origin/matmul' into matmul
wassup05 7e296bb add comments to the example
wassup05 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added tests
- Loading branch information
commit cee5bba407d0358230afcbb7ac3553bd7859105b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm probably late for this party but isn't
epsilon(0.0_wp)like the smallest number that can be represented in the working precisionwp? If it is indeed the case, then I wouldn't be surprised to see the tests fail.I guess, a better indicator would be to consider the matrix 2-norm (i.e. the largest singular value of$A - \tilde{A}$ where $A$ is the matrix you'd compute with a chain of $\tilde{A}$ the one from your implementation).
matmulandUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be
tiny(0.0)which is indeed a very tiny number.epsilon()represents the smallest significant difference between two consecutive real numbers in the given precision.