-   Notifications  You must be signed in to change notification settings 
- Fork 196
linalg: Schur decomposition #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @perazz . It is a nice addition. I only have a few minor comments. So, it is close to be ready to be merged IMO
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
| Thanks for the reviews @jvdp1, looks much better now. Regarding the eigenvalues,  Sorry I just realized we had the approach in place for  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @perazz . LGTM. It is ready to be merged IMO
| Thank you @jvdp1, let's wait another couple of days, and then merge if there are no further comments. | 
Compute the Schur decomposition of a$A = Z T Z^H$ .
realorcomplexsquare matrix:Proposed implementation
call schur(A, T [, Z] [, eigvals] [, overwrite_a] [, storage] [, err]): subroutine interfacecall schur_space(A, lwork [, err])query internal storage size for pre-allocation.Key facts
*GEES) and eigenvalue sorting mechanisms.overwrite_aflag (default:.false.). If.true., andstorageis user-provided, the input matrixawill be overwritten, avoiding memory allocation.Progress
Prior art
T, Z = schur(a, output='real', lwork=None, overwrite_a=False, sort=None, check_finite=True)cc: @fortran-lang/stdlib @jvdp1 @jalvesz @loiseaujc