Skip to content
This repository was archived by the owner on Sep 29, 2023. It is now read-only.

Conversation

@amir-the-h
Copy link

@amir-the-h amir-the-h commented Aug 19, 2023

Changes

  • Removed extra inputPipeWriter, and outputPipeReader since there was no use for them
  • Fixed the GetMetadata method to work with input pipe
  • Added more properties based on the attached ffprobe response:
{ "streams": [ { "index": 0, "codec_name": "h264", "codec_long_name": "H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10", "profile": "Main", "codec_type": "video", "codec_tag_string": "avc1", "codec_tag": "0x31637661", "width": 1280, "height": 720, "coded_width": 1280, "coded_height": 720, "closed_captions": 0, "film_grain": 0, "has_b_frames": 1, "sample_aspect_ratio": "1:1", "display_aspect_ratio": "16:9", "pix_fmt": "yuv420p", "level": 31, "color_range": "tv", "color_space": "bt709", "color_transfer": "bt709", "color_primaries": "bt709", "chroma_location": "left", "field_order": "progressive", "refs": 1, "is_avc": "true", "nal_length_size": "4", "id": "0x1", "r_frame_rate": "30000/1001", "avg_frame_rate": "30000/1001", "time_base": "1/30000", "start_pts": 0, "start_time": "0.000000", "duration_ts": 78172094, "duration": "2605.736467", "bit_rate": "1269470", "bits_per_raw_sample": "8", "nb_frames": "78094", "extradata_size": 42, "disposition": { "default": 1, "dub": 0, "original": 0, "comment": 0, "lyrics": 0, "karaoke": 0, "forced": 0, "hearing_impaired": 0, "visual_impaired": 0, "clean_effects": 0, "attached_pic": 0, "timed_thumbnails": 0, "captions": 0, "descriptions": 0, "metadata": 0, "dependent": 0, "still_image": 0 }, "tags": { "creation_time": "2022-02-23T23:15:22.000000Z", "language": "und", "handler_name": "ISO Media file produced by Google Inc. Created on: 02/23/2022.", "vendor_id": "[0][0][0][0]" } }, { "index": 1, "codec_name": "aac", "codec_long_name": "AAC (Advanced Audio Coding)", "profile": "LC", "codec_type": "audio", "codec_tag_string": "mp4a", "codec_tag": "0x6134706d", "sample_fmt": "fltp", "sample_rate": "44100", "channels": 2, "channel_layout": "stereo", "bits_per_sample": 0, "id": "0x2", "r_frame_rate": "0/0", "avg_frame_rate": "0/0", "time_base": "1/44100", "start_pts": 0, "start_time": "0.000000", "duration_ts": 114913280, "duration": "2605.743311", "bit_rate": "127999", "nb_frames": "112220", "extradata_size": 16, "disposition": { "default": 1, "dub": 0, "original": 0, "comment": 0, "lyrics": 0, "karaoke": 0, "forced": 0, "hearing_impaired": 0, "visual_impaired": 0, "clean_effects": 0, "attached_pic": 0, "timed_thumbnails": 0, "captions": 0, "descriptions": 0, "metadata": 0, "dependent": 0, "still_image": 0 }, "tags": { "creation_time": "2022-02-23T23:15:22.000000Z", "language": "und", "handler_name": "ISO Media file produced by Google Inc. Created on: 02/23/2022.", "vendor_id": "[0][0][0][0]" } } ], "format": { "filename": "Compton.mp4", "nb_streams": 2, "nb_programs": 0, "format_name": "mov,mp4,m4a,3gp,3g2,mj2", "format_long_name": "QuickTime / MOV", "start_time": "0.000000", "duration": "2605.743300", "size": "456488676", "bit_rate": "1401484", "probe_score": 100, "tags": { "major_brand": "mp42", "minor_version": "0", "compatible_brands": "isommp42", "creation_time": "2022-02-23T23:15:22.000000Z" } } }
@amir-the-h amir-the-h marked this pull request as draft August 19, 2023 15:43
@amir-the-h amir-the-h closed this Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant