Fixes type returned by index function #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonathan-beebe commented Apr 10, 2018
| | ||
| export interface TestFeatureList extends FeaturesList { | ||
| cleanup(); | ||
| } |
There was a problem hiding this comment.
I am not super excited about the name TestFeatureList. I created it more as a proof of concept for the fix.
| Thanks for the proof of concept! I made #14 inspired by your PR. Closing this one in lieu of that one. |
laurenzlong added a commit that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
I believe this fixes issue #7. I have been in conversation with the Firebase support team about this. Below is a super simple example of the issue I sent them.
Code sample
Before the following code would throw an error
error TS2339: Property 'cleanup' does not exist on type 'FeaturesList'.Now with the new type
TestFeatureListthecleanupfunction exists on the return type offunctionsTest()and the code compiles and runs as expected.