Skip to content

GMA Integration Test - NoFill Retry #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

GMA Integration Test - NoFill Retry #983

wants to merge 21 commits into from

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jun 7, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Numerous updates to the GMA Integration Tests to increase CI stability:

  • Added detection of NoFill and BackOff errors sent by the AdMob service. The iTest will pause and retry the add load in these situations. The maximum number of retires has been limited to 15.
  • Added a SKIP_TEST_ON_SIMULATOR to the Firebase App Test Framework.
  • Due to the higher chance of NoFill errors occuring when running on local simulators, all LoadAd operations are skipped on simulators.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Local Tests on Android / iOS Simulators, and Android / iOS real devices.
Integration Tests

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.
DellaBitta added 20 commits May 28, 2022 16:26
@DellaBitta
bounding box listener log
4e36fcd
@DellaBitta
pause longer for callbacks
c820f99
@DellaBitta
Debug logging on ad load errors
76d9595
@DellaBitta
LoadAd reattempt for one test
c4df0ce
@DellaBitta
pause for 60 seconds on no fill
71c3293
@DellaBitta
bounding box changes baseline
7746fc5
@DellaBitta
Pause debug logging
980e6d4
@DellaBitta
Disable stress tests
bc08554
@DellaBitta
made a colon more semi
3b10eba
@DellaBitta
Update retries across all applicable load ad operations
6bcb69e
@DellaBitta
mainly empty AdRequest. Stop testing when load failed
8eb6f10
@DellaBitta
no custom ad requests
b04b162
@DellaBitta
coalesce load ad operations
ca36cf2
@DellaBitta
fix retry loop, disabled stress tests
ffde303
@DellaBitta
add an exclude_list to test_simulator
c562203
@DellaBitta
add gma exclusion to integration test workflow
03724df
@DellaBitta
added skip test on simulator for loadAd tests
5fe0fcc
@DellaBitta
removed exclude tests from intergration test workflow
3029240
@DellaBitta
add SKIP_TEST_ON_SIMULATOR to firebase_test_framework.h
3bb64ca
@DellaBitta
format
3e48739
@DellaBitta DellaBitta changed the title Bugfix/gma bb listener flake GMA Integration Test - NoFill Retry Jun 7, 2022
@DellaBitta DellaBitta closed this Jun 7, 2022
@DellaBitta DellaBitta deleted the bugfix/gma_bb_listener_flake branch June 7, 2022 14:52
@firebase firebase locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant

@DellaBitta