Skip to content

Conversation

@AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented May 19, 2022

Description

Adds InitiateOnDeviceConversionMeasurementWithEmail to the Analytics API as described in go/ga4f-odm-api
On iOS this just passes through to the corresponding method in the iOS SDK
On Android this is no-op.


Testing

Added unit and integration tests that call the function. No expectations other than that the relevant function is called since all functional logic is in underlying iOS SDK.

Manually ran integration test that calls thew new method to verify that the underlying iOS SDK logs "Failed to initiate on-device conversion measurement. GoogleAppMeasurementOnDeviceConversion dependency not linked in." if the relevant dependency is not linked in, and that the same error message is not logged if the dependency is linked. This verifies that the relevant code is being run and that the code compiles whether or not the dependency is present.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@AlmostMatt AlmostMatt added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 19, 2022
@AlmostMatt AlmostMatt requested a review from DellaBitta May 19, 2022 17:30
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels May 19, 2022
@github-actions
Copy link

github-actions bot commented May 19, 2022

✅  Integration test succeeded!

Requested by @AlmostMatt on commit 533a317
Last updated: Mon May 30 11:03 PDT 2022
View integration test log & download artifacts

@AlmostMatt AlmostMatt removed the request for review from DellaBitta May 19, 2022 17:32
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 19, 2022
@AlmostMatt AlmostMatt requested a review from DellaBitta May 19, 2022 18:59
@AlmostMatt AlmostMatt removed the tests: failed This PR's integration tests failed. label May 19, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 19, 2022
@AlmostMatt AlmostMatt added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels May 19, 2022
@github-actions github-actions bot added tests: failed This PR's integration tests failed. tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 19, 2022
@AlmostMatt AlmostMatt added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 20, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 20, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 20, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 20, 2022
@AlmostMatt AlmostMatt added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label May 24, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: failed This PR's integration tests failed. labels May 24, 2022
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 24, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 24, 2022
@DellaBitta DellaBitta removed the tests: failed This PR's integration tests failed. label May 26, 2022
@AlmostMatt AlmostMatt merged commit 533a317 into main May 30, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. labels May 30, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 30, 2022
@firebase firebase locked and limited conversation to collaborators Jun 30, 2022
@AlmostMatt AlmostMatt deleted the almostmatt-initiate-device-conversion branch October 20, 2022 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests: succeeded This PR's integration tests succeeded.

2 participants