- Notifications
You must be signed in to change notification settings - Fork 126
Add InitiateOnDeviceConversion method to Analytics #961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
✅ Integration test succeeded!Requested by @AlmostMatt on commit 533a317 |
…ics integration test Podfile
DellaBitta requested changes May 20, 2022
DellaBitta approved these changes May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Adds InitiateOnDeviceConversionMeasurementWithEmail to the Analytics API as described in go/ga4f-odm-api
On iOS this just passes through to the corresponding method in the iOS SDK
On Android this is no-op.
Testing
Added unit and integration tests that call the function. No expectations other than that the relevant function is called since all functional logic is in underlying iOS SDK.
Manually ran integration test that calls thew new method to verify that the underlying iOS SDK logs "Failed to initiate on-device conversion measurement. GoogleAppMeasurementOnDeviceConversion dependency not linked in." if the relevant dependency is not linked in, and that the same error message is not logged if the dependency is linked. This verifies that the relevant code is being run and that the code compiles whether or not the dependency is present.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.