promise_main.h: fix race conditions #799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dconeybe added the tests-requested: quick 
github-actions bot added tests: in-progress 
❌ Integration test FAILEDRequested by @dconeybe on commit 52902ce
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger bot removed the tests: in-progress 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix race conditions in
promise_main.hrelated to when theCleanupNotifierandReferenceCountedFutureImplobjects that it references are deleted.Googlers can see b/173819915 for details.