Skip to content

Disable more bundles tests that fail in Windows CI #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2021
Merged

Disable more bundles tests that fail in Windows CI #440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions firestore/integration_test_internal/src/bundle_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,10 @@ TEST_F(BundleTest, LoadInvalidBundlesShouldFail) {
}

TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
// local run is fine. We need to figure out why and re-enable it.
SKIP_TEST_ON_WINDOWS;

Firestore* db = TestFirestore();
auto collection = db->Collection("coll-1");
WriteDocuments(collection,
Expand Down Expand Up @@ -273,6 +277,10 @@ TEST_F(BundleTest, LoadBundleWithDocumentsAlreadyPulledFromBackend) {
}

TEST_F(BundleTest, LoadedDocumentsShouldNotBeGarbageCollectedRightAway) {
// TODO(wuandy, b/189477267): This test fails on Windows CI, but
// local run is fine. We need to figure out why and re-enable it.
SKIP_TEST_ON_WINDOWS;

Firestore* db = TestFirestore();
// This test really only makes sense with memory persistence, as disk
// persistence only ever lazily deletes data.
Expand Down