Skip to content

Conversation

@ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 6, 2021

Will investigate and re-enable the test when the cause is found.

Will investigate and re-enable the test when the cause is found.
@ehsannas ehsannas requested a review from var-const May 6, 2021 21:57
@ehsannas ehsannas self-assigned this May 6, 2021
@ehsannas ehsannas added the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2021
@google-cla google-cla bot added the cla: yes label May 6, 2021
@ehsannas ehsannas changed the title Disable test that seems to time out on Android. Disable a test that seems to time out on Android. May 6, 2021
@var-const
Copy link
Contributor

For the record, here's the link to a failing run: https://github.com/firebase/firebase-cpp-sdk/runs/2516720057

jonsimantov
jonsimantov previously approved these changes May 6, 2021
Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also disable this only on Android by adding SKIP_TEST_ON_ANDROID; as the first line of the function body (macro is defined in firebase_test.h)

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 6, 2021
@github-actions
Copy link

github-actions bot commented May 6, 2021

❌  Integration test FAILED

Requested by @var-const on commit 78e65e1
Last updated: Thu May 6 17:36:38 PDT 2021
View integration test results

Platform Build failures Test failures
Android hardware (built on Linux) firestore
remote_config
Android hardware (built on MacOS) firestore
remote_config
Android hardware (built on Windows) firestore

@jonsimantov jonsimantov removed the tests-requested: quick Trigger a quick set of integration tests. label May 6, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 6, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 7, 2021
@github-actions github-actions bot removed the tests: failed This PR's integration tests failed. label May 7, 2021
@ehsannas
Copy link
Contributor Author

ehsannas commented May 7, 2021

Closing this in favor of #417

@ehsannas ehsannas closed this May 7, 2021
@ehsannas ehsannas deleted the add-source-tests-3 branch May 7, 2021 04:17
@firebase firebase locked and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 participants