Port cl/362275804: Fix build error in promise_android_test.cc #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
schmidt-sebastian approved these changes Mar 18, 2021
dconeybe added a commit that referenced this pull request Mar 30, 2021
This changelist was previously ported in #331 but the integration testing component was lost in a merge. As a benefit, this also fixes the broken promise_android_test.cc tests.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a port of cl/362275804. The changelist in google3 fixed some build logic that caused some tests to be excluded from continuous runs. That allowed
promise_android_test.ccto get stale and fail to build. This PR fixes the build error inpromise_android_test.ccthat was discovered by the build fix. The build fix itself is not relevant for GitHub.