Skip to content

Conversation

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@crazyhappygame
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@crazyhappygame
Copy link
Author

@stewartmiles could you merge it?

@crazyhappygame
Copy link
Author

@a-maurice could you merge it?

@a-maurice
Copy link
Contributor

Hi @crazyhappygame, sorry for the delay in getting back to you. Unfortunately, we have run into a couple roadblocks that have prevented us from setting up the repo to take in pull requests through GitHub (changes are being brought over from another repo, and it is currently one way, so this change would risk getting blown away). The change does look reasonable though, so if you are fine with it, I can replicate your change into that repo, and push it onto this.

@crazyhappygame
Copy link
Author

Ok

@DellaBitta DellaBitta closed this Feb 24, 2021
@DellaBitta DellaBitta deleted the branch firebase:main February 24, 2021 18:46
@DellaBitta DellaBitta reopened this Feb 25, 2021
@DellaBitta DellaBitta changed the base branch from master to main February 25, 2021 14:30
@crazyhappygame
Copy link
Author

@a-maurice @DellaBitta I checked the latest version 8.3 and those changes are still not there...
Could you merge it?

@crazyhappygame crazyhappygame closed this by deleting the head repository Dec 17, 2022
@firebase firebase locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4 participants