Add desktop builds to C++ packaging workflow. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jonsimantov changed the title 
| Latest run of this workflow is here: https://github.com/firebase/firebase-cpp-sdk/actions/runs/296224619 |
vimanyu approved these changes Oct 9, 2020
There was a problem hiding this comment.
LGTM! Super exciting to see pacakged artifacts in the workflow!
I wish there was a better way to compose/reuse a workflow in another workflow. I did notice Github actions team launching a new feature recently to address something on those lines but didnt see a good way of integrating it for us right away.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add desktop build to C++ packaging workflow, using existing desktop python scripts. (This omits pre-packaging testing, as testing will be done on the packaged SDK.)