Skip to content

Feature/android builds on windows clean #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 24, 2020
Merged

Feature/android builds on windows clean #150

merged 8 commits into from
Sep 24, 2020

Conversation

@vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Sep 21, 2020

Changes to build android libraries on Windows

  • Added an action to install msbuild tools before our build step (msbuild tools are required to download and install external dependencies like flatbuffers, firestore etc. Without this step, the build step fails silently without any obvious errors)
  • Using simple cp on Windows instead of rsync as that would have required and additional download/install of rsync.
  • Downloading and unpacking "strings" (a tool required only for Windows builds) at the root of the repo.
@vimanyu vimanyu self-assigned this Sep 21, 2020
DellaBitta
DellaBitta previously approved these changes Sep 22, 2020
View reviewed changes
@vimanyu vimanyu dismissed stale reviews from anonymous-akorn and DellaBitta via 40f82d4 September 23, 2020 00:25
@vimanyu vimanyu merged commit 92d8bc1 into dev Sep 24, 2020
@vimanyu vimanyu deleted the feature/android-builds-on-windows-clean branch September 24, 2020 17:37
@firebase firebase locked and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes

4 participants

@vimanyu @DellaBitta @anonymous-akorn @googlebot