Skip to content

Use core implementation of aggregate query equality operator. #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use core implementation of aggregate query equality operator. #1376

merged 1 commit into from
Jun 30, 2023

Conversation

@tom-andersen
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.
@tom-andersen tom-andersen requested a review from dconeybe June 29, 2023 20:48
@tom-andersen tom-andersen added the skip-release-notes Skip release notes check label Jun 29, 2023
@tom-andersen tom-andersen enabled auto-merge (squash) June 29, 2023 21:03
@tom-andersen tom-andersen merged commit 6068798 into main Jun 30, 2023
@dconeybe dconeybe deleted the tomandersen/aggregateQueryEquals branch June 30, 2023 05:55
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @tom-andersen on commit 6068798
Last updated: Fri Jun 30 01:35 PDT 2023
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 30, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2023
tom-andersen added a commit that referenced this pull request Jul 17, 2023
@tom-andersen
Use core implementation of aggregate query equality operator. (#1376)
cdcfda9
@firebase firebase locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

2 participants

@tom-andersen @dconeybe