Skip to content

Conversation

@DellaBitta
Copy link
Contributor

Fixes for the Storage integration test. The test would timeout on Windows when attempting to sign in a user anonymously, though it would work for the first sign in attempt, just not subsequent ones.

I pulled in the auth teardown logic.

Additionally removed an unneeded check for app initialization in the teardown method. This check is already being done by the sub-methods.

Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DellaBitta DellaBitta merged commit c8661cf into dev Sep 9, 2020
@DellaBitta DellaBitta deleted the feature/ddb-win-storage-timeout branch September 9, 2020 17:42
@firebase firebase locked and limited conversation to collaborators Oct 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 participants