adding absl_variant as a dependency #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We were seeing linker symbols missing errors when this wasn't included. Turns out only the C++ part of firestore depends on this. firestore_core doesnt depend on this and hence doesnt transitively bring this in.
a-maurice approved these changes Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes linker symbol missing errors discovered when building firestore's integration tests. This dependency absl_types is used just by the C++ part of Firestore and hence was not pushed to "firebase-ios-sdk" repo.
We were seeing errors like these,
undefined reference to `absl::lts_2020_02_25::variant_internal::ThrowBadVariantAccess()