Skip to content

Feature/ddb storage pause test #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Feature/ddb storage pause test #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e220296
reduce time before pausing
DellaBitta Sep 2, 2020
7eaf454
Process events only while bytes haven't trasnferred.
DellaBitta Sep 2, 2020
8a349c3
debug log in onpause listener
DellaBitta Sep 2, 2020
6abdd4f
add better check for download transfer starts before pause/cancel
DellaBitta Sep 2, 2020
6db354b
got my lt crossed with my gt
DellaBitta Sep 2, 2020
a305927
.
DellaBitta Sep 3, 2020
7cea7f3
.
DellaBitta Sep 3, 2020
e0619eb
revert and restart
DellaBitta Sep 3, 2020
1d31308
.
DellaBitta Sep 3, 2020
2188c3b
cancel download now uses process events 1
DellaBitta Sep 3, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firestore/integration_test/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6-all.zip
20 changes: 16 additions & 4 deletions storage/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,10 @@ TEST_F(FirebaseStorageTest, TestLargeFilePauseResumeAndDownloadCancel) {
// operation.
ASSERT_TRUE(controller.is_valid());

ProcessEvents(500);
while(controller.bytes_transferred() == 0)
{
ProcessEvents(1);
}
// After waiting a moment for the operation to start, pause the operation
// and verify it was successfully paused. Note that pause might not take
// effect immediately, so we give it a few moments to pause before
Expand Down Expand Up @@ -638,7 +641,11 @@ TEST_F(FirebaseStorageTest, TestLargeFilePauseResumeAndDownloadCancel) {
ref.GetBytes(&buffer[0], kLargeFileSize, &listener, &controller);
ASSERT_TRUE(controller.is_valid());

ProcessEvents(500);
while(controller.bytes_transferred() == 0)
{
ProcessEvents(1);
}

LogDebug("Pausing download.");
EXPECT_TRUE(controller.Pause()) << "Download pause";

Expand Down Expand Up @@ -691,7 +698,12 @@ TEST_F(FirebaseStorageTest, TestLargeFilePauseResumeAndDownloadCancel) {
firebase::Future<size_t> future =
ref.GetBytes(&buffer[0], kLargeFileSize, &listener, &controller);
ASSERT_TRUE(controller.is_valid());
ProcessEvents(500);

while(controller.bytes_transferred() == 0)
{
ProcessEvents(1);
}

LogDebug("Cancelling download.");
EXPECT_TRUE(controller.Cancel());
WaitForCompletion(future, "GetBytes", firebase::storage::kErrorCancelled);
Expand Down Expand Up @@ -773,4 +785,4 @@ TEST_F(FirebaseStorageTest, TestInvalidatingReferencesWhenDeletingApp) {
EXPECT_FALSE(metadata.is_valid());
}

} // namespace firebase_testapp_automated
} // namespace firebase_testapp_automated