iOS support for multiple User objects #1242
Conversation
github-actions bot added the tests: in-progress 
❌ Integration test FAILEDRequested by @DellaBitta on commit c208b23
Add flaky tests to go/fpl-cpp-flake-tracker |
firebase-workflow-trigger bot removed the tests: in-progress ![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| UserInternal* user_internal_; | ||
| }; | ||
| | ||
| } // namespace auth |
There was a problem hiding this comment.
📝 Documentation issue: [3 lines down] warning: More #endif's than #if's found.
| ~User(); | ||
| | ||
| /// Returns whether this User object represents a valid user. Could be false | ||
| /// on Users contained with @ref AuthResult structures from failed Auth |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'AuthResult' for \ref command
| const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref LinkAndRetrieveDataWithCredential(const Credential&) instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'LinkAndRetrieveDataWithCredential(const Credential&)' for \ref command
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref LinkWithCredential_DEPRECATED. | ||
| FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED() |
There was a problem hiding this comment.
📝 Documentation issue: [10 lines up] warning: unable to resolve reference to 'LinkWithCredential(const Credential&)' for \ref command
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref LinkWithCredential_DEPRECATED. | ||
| FIREBASE_DEPRECATED Future<User*> LinkWithCredentialLastResult_DEPRECATED() |
There was a problem hiding this comment.
📝 Documentation issue: [8 lines up] warning: unable to resolve reference to 'ReauthenticateAndRetrieveData' for \ref command
| LinkAndRetrieveDataWithCredentialLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref LinkWithProvider(FederatedAuthProvider*) instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'LinkWithProvider(FederatedAuthProvider*)' for \ref command
| FIREBASE_DEPRECATED Future<SignInResult> LinkWithProvider_DEPRECATED( | ||
| FederatedAuthProvider* provider) const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use @ref Unlink(const |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| | ||
| /// @deprecated | ||
| /// | ||
| /// Get results of the most recent call to @ref Unlink. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'Unlink' for \ref command
| FIREBASE_DEPRECATED Future<User*> UnlinkLastResult_DEPRECATED() const; | ||
| | ||
| /// @deprecated This is a deprecated method. Please use | ||
| /// @ref UpdatePhoneNumberCredential(const PhoneAuthCredential&) instead. |
There was a problem hiding this comment.
📝 Documentation issue: warning: unable to resolve reference to 'UpdatePhoneNumberCredential(const PhoneAuthCredential&)' for \ref command
1 participant
Description
Update auth internals to support returning Future object for the new API while also support returning Future<User*> objects for the deprecated API on iOS.
Changes does not include the new Future methods.
Testing
Locally run integration test on device.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.